add multiclass support for hyperopt utl #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wpal_wabbit into hyperopt_multiclass_clf
arielf
reviewed
Nov 26, 2018
| @@ -219,11 +220,16 @@ def get_hyperparam_string(self, **kwargs): | |||
| def compose_vw_train_command(self): | |||
| data_part = ('vw -d %s -f %s --holdout_off -c ' | |||
| % (self.train_set, self.train_model)) | |||
| if self.labels_clf_count > 2: # multiclass, should take probabilities | |||
| data_part += ('--oaa %s --loss_function=logistic --probabilities ' | |||
There was a problem hiding this comment.
Would be nice to support other multiclass methods in addition to --oaa.
e.g.: --ect, --recall_tree, --wap, (with & without ldf) etc.
They all have similar interface (expect number of classes as arg)
|
I'm going to merge this because it seems better to have some multiclass support than none. @arielf or others, feel free to tweak to add more multiclass support. |
jackdoe
pushed a commit
to lucjb/vowpal_wabbit
that referenced
this pull request
Mar 7, 2019
* add multiclass support * remove debugging print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for multiclass classification problems.
Also, find out that we have to speed up script to make it actually useful.